test(@angular-devkit/build-angular): add application/browser test runs #28479
Conversation
jkrems
force-pushed
the
jk-karma-app-test
branch
from
5f5461a to
febd808
Compare
| watch: false, | ||
| }); | ||
|
|
||
| const optionSchemaCache = new Map<string, json.schema.JsonSchema>(); |
There was a problem hiding this comment.
This code is similar to the dev-server code and could likely be refactored to be shared across builders: https://github.com/angular/angular-cli/blob/main/packages/angular_devkit/build_angular/src/builders/dev-server/tests/jasmine-helpers.ts#L18-L25
There was a problem hiding this comment.
I'd like to improve the test harness in general so that refactor could fit in there. Probably a good item for the next fixit.
jkrems
force-pushed
the
jk-karma-app-test
branch
from
febd808 to
170468f
Compare
Runs all existing karma tests twice: Once in an environment that uses the application builder and once in one that uses the browser builder. The general approach is taken from the dev server tests. This is in preparation for supporting the application builder for karma tests.
jkrems
force-pushed
the
jk-karma-app-test
branch
from
170468f to
82b0464
Compare
| "extract-i18n": {}, | ||
| "karma": { | ||
| "shards": 3, | ||
| "shards": 6, |
There was a problem hiding this comment.
Theory: We're doubling the number of tests, so we can (and should) double the number of shards.
jkrems
added
the
action: review
|
(Switching reviewers after checking champion of the application builder feature gap work in general.) |
jkrems
added
action: merge
|
The changes were merged into the following branches: main, 18.2.x |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Runs all existing karma tests twice: Once in an environment that uses the application builder and once in one that uses the browser builder. The general approach is taken from the dev server tests.
This is in preparation for supporting the application builder for karma tests.
PR Checklist
Please check to confirm your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
All karma builder-related tests are run twice: Once in a harness that includes a "browser" development builder and once with a "application" development builder.
Does this PR introduce a breaking change?
Other information